Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow signature in dynamic text #298

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

maharshivpatel
Copy link
Collaborator

@maharshivpatel maharshivpatel commented Jun 21, 2024

signature field is saved as base64 encoded string in the database. i just added img tag and set the src attribute to the base64 encoded string.

Screen.Recording.2024-06-21.at.11.34.35.AM.mov

fixes #110 #276

signature field is saved as base64 encoded string in the database.
i just added img tag and set the src attribute to the base64 encoded string.
@maharshivpatel maharshivpatel merged commit 4fd5e74 into frappe:develop Jun 24, 2024
1 check passed
@2old4thisShit 2old4thisShit mentioned this pull request Jun 24, 2024
@maharshivpatel
Copy link
Collaborator Author

🎉 This issue has been resolved in version 1.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@batonac
Copy link
Contributor

batonac commented Aug 28, 2024

This works really well. Thanks @maharshivpatel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Enable Signature field as "Dynamic Image"
2 participants